uber / uber/NullAway

Does not support EnsuresNonNull

Open
#115 1 comment 1 reaction 1 assignee View on GitHub

@lazaroclapp is already working on this.

Since Jan 8, 2018.

enhancement
Dominant language
Java
Stars
4.1k
Forks
370
Avg merge
1d 13h
Merged PRs (30d)
68

Description

I suppose NullAway does not perform complex data flow analysis now, so cannot handle the following example. Besides suppressing this warning, how can we handle this in NullAway?

public class CharSequenceReader {

private int pos;
@Nullable private CharSequence seq;

@EnsuresNonNull("this.seq")
private void checkOpen() throws IOException {
if (seq == null) {
throw new IOException("Not open.");
}
}

public int read() throws IOException {
checkOpen();
return seq.charAt(pos++); // NullAway warns here.
}

}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.