uNetworking / uNetworking/uWebSockets
App.filter should emit decrement when upgrading to websocket
Open
Nobody has claimed this yet.
API-breaking
- Dominant language
- C++
- Stars
- 19k
- Forks
- 1.9k
- Avg merge
- 3h 24m
- Merged PRs (30d)
- 5
Description
Currently you need to track App.filter events and websocket .close to get accurate connection number.
- Either App.filter should decrement when websocket.close happens (not possible)
- Or, App.filter should decrement when upgrading to websocket so that a second count for websockets can be kept from open/close events (possible).
- App.filter decrement should emit AFTER websocket upgrade so that the counter won't flicker at 0
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files or tests are named. Start by tracing App.filter event handling and the websocket upgrade path; verify how connection counts change during an upgrade. Done means App.filter emits its decrement after the websocket upgrade, without a transient zero count.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- networking
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100