uNetworking / uNetworking/uWebSockets
closeOnBackpressure should block all further sending
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 19k
- Forks
- 1.9k
- Avg merge
- 3h 24m
- Merged PRs (30d)
- 5
Description
When we reach maxBackpressure we start closing the connection (which doesn't even work on Windows!). But there is no guarantee that backpressure won't drain a bit and we then send another message still. This can cause a gap in the stream. This needs to be guaranteed that when we reach maxBackpressure and we are closing, never send anything more. To guarantee stream integrity.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the maxBackpressure handling and the connection send path. Confirm how backpressure can drain during connection closing, then verify that reaching maxBackpressure prevents every later send and preserves stream integrity, including on Windows.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100