uNetworking / uNetworking/uWebSockets
AsyncSocket::write, uncork needs to return PROGRESS
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 19k
- Forks
- 1.9k
- Avg merge
- 3h 24m
- Merged PRs (30d)
- 5
Description
written, failed, progress needs to be returned so that proper timeout logic can be implemented. Currently we only reset timeout on success but we really should reset it on any progress. Also, we reset timeout if written to work buffer, which is not completely correct either.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating AsyncSocket::write and the uncork path in the uWebSockets source, then trace how its written and failed results currently affect timeout handling. Confirm how PROGRESS is represented and identify the relevant tests or timeout behavior to exercise. Done means progress is returned distinctly and timeout reset logic reflects actual progress rather than only writes to the work buffer.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100