uNetworking / uNetworking/uSockets

when using epoll, I guess any fallthrough-poll should not be closed?

Open
#52 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug wontfix
Dominant language
C
Stars
1.5k
Forks
307
PR merge metrics
No merged PRs in 30d

Description

I read the eventing/epoll.c.
When create fallthrough-poll, it doesn't touch loop->num_polls.
When close fallthrough-poll, it will do loop->num_polls--.
It is a designed behavior and imply fallthrough-poll may not be closed? or I miss sth?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in eventing/epoll.c and compare how fallthrough-poll creation and closure update loop->num_polls. Trace the relevant loop and poll lifecycle, then determine whether the accounting is intentional or whether closing a fallthrough-poll leaves an invariant violated.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
networking
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.