typst / typst/package-check

Adjust licence check to match new requirements

Open
#21 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
36
Forks
9
Avg merge
1h 46m
Merged PRs (30d)
1

Description

Since certain CC Licences are now allowed to be used (e.g. with citestyles in our case) the licence check does not work correctly anymore.

The is_osi_approved function at src/check/manifest.rs:530 is throwing the error.

Reference to the changes in the packages repo:
https://github.com/typst/packages/issues/1511
https://github.com/typst/packages/pull/1521

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/check/manifest.rs at is_osi_approved around line 530. Read the linked packages issue and pull request to identify which Creative Commons licences are now allowed, then inspect existing licence-check tests or run the project’s test suite. Done means the checker accepts the newly permitted licences while still rejecting disallowed ones.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.