typst / typst/codex

Numbering pattern "가" sequence needs change

Open
#161 4 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
53
Forks
22
PR merge metrics
No merged PRs in 30d

Description

Description

Currently, the "가" numbering pattern has the following sequence

가나다라마바사아자차카타파하

and after that, it ends, and displaying the 29th numbering will result to "가가". But, in fact it should be "거". According to Korean government standards, the order should be the combination of plain consonants ㄱㄴㄷㄹㅁㅅㅇㅈㅊㅋㅌㅍㅎ and short vowels(monopthongs)ㅏㅓㅗㅜㅡㅣ. So it would be
가나다라마바사아자차카타파하 -> 거너더...허 -> 고노도...호 -> 구누두...후 -> ...
The current situation can be described as similar to a scenario where 'ああ いい ...' follows 'あ い う え お' in the Japanese "あ" numbering pattern. (This is just a metaphor? and currently typst works as it should where it displays "か" after "お")

Here is my implementation of the numbering system(plus a hard coded solution to typst/typst#6484[https://github.com/typst/typst/issues/6484])

#let traditional-numbering(format, ..args) = {
    let result = numbering(format, ..args)

    let n = args.pos().first()

    if format == "가" {
        // Hangul combination formula: 0xAC00 + (consonant index * 21 * 28) + (vowel index * 28)
        // 1. plain consonants (ㄱ, ㄴ, ㄷ, ㄹ, ㅁ, ㅂ, ㅅ, ㅇ, ㅈ, ㅊ, ㅋ, ㅌ, ㅍ, ㅎ)
        let c_map = (0, 2, 3, 5, 6, 7, 9, 11, 12, 14, 15, 16, 17, 18)
        // 2. short vowels (ㅏ, ㅓ, ㅗ, ㅜ, ㅡ, ㅣ)
        let v_map = (0, 4, 6, 12, 13, 18, 20)

        let c_idx = calc.rem(n - 1, 14)
        let v_idx = calc.floor((n - 1) / 14)

        if v_idx < v_map.len() {
            let char_code = 0xAC00 + (c_map.at(c_idx) * 21 * 28) + (v_map.at(v_idx) * 28)
            result = str.from-unicode(char_code)
        } else {
            result = numbering(format, ..args)
        }
    } else {
        result = numbering(format, ..args)
    }

    result
        .replace("贰", "貳") // 2
        .replace("叁", "參") // 3 
        .replace("陆", "陸") // 6
        //    .replace("万", "萬")
        .replace("亿", "億") // 100 million
}

Below is the result of this code

#for i in range(1, 85) [
    #traditional-numbering("가", i)
]
가 나 다 라 마 바 사 아 자 차 카 타 파 하 거 너 더 러 머 버 서 어 저 처 커 터 퍼 허 고 노 도 로 모 보 소 오 조 초 코 토 포 호 구 누 두 루 무 부 수 우 주 추 쿠 투 푸 후 그 느 드 르 므 브 스 으 즈 츠 크 트 프 흐 기 니 디 리 미 비 시 이 지 치 키 티 피 히 

Thank you for looking in!

Use Case

This would make typst numbering match the Korean standards (from the government or the HWP word processor)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the numbering implementation for the "가" format and compare its current sequence with the Korean government standard described in the issue. Use the supplied Hangul combination logic and expected output as the reference, then verify that numbering continues through the listed vowel groups without producing "가가" for 29.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
internationalization
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.