typetools / typetools/checker-framework
Purity Checker suggests @Pure for interface method whose implementations are not @Pure
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 1.1k
- Forks
- 440
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 134
Description
The Purity Checker (invoked with the -AsuggestPureMethods option) currently can suggest @Pure for an interface method declaration even when the implementations of that method in the same project are not @Pure.
A two-pass approach should be implemented such that once the implementations of an interface method have been visited, the suggestion for the interface method is revised.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the Purity Checker entry point used by the -AsuggestPureMethods option and trace how interface methods and their implementations are visited. Done means the interface method is not suggested as @Pure when a same-project implementation is not @Pure, after the implementations have been considered.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100