typetools / typetools/checker-framework

Tests should be run with caching turned off (and on)

Open
#601 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug nondeterminism
Dominant language
Java
Stars
1.1k
Forks
440
Avg merge
1d 12h
Merged PRs (30d)
134

Description

All tests should be run with caching turned off to ensure the results are identical to the results when caching is turned on. (Though the test will take longer without caching)
Categories of bugs:

  • Loops (Proposed solution: #602)
  • Fields (Fixed via 1b239a0)
  • Raw types (Fixed via dbaa1b4)
  • Lambdas (Fixed via #638)

More details:

Turning off caching in the AnnotatedTypeFactory results in three test failures:

  • Value Checker: value/Repo.java (refined types in loop #602)
  • Interning Checker: interning/CompileTimeConstants.java (fields)
  • NullnessChecker: jtreg/rawtypes/RawTypeFail.java (raw types)

The skipped tests for Issue #345 (nullness/AssignmentDuringInitialization.java, nullness/Issue345.java) pass with caching turned off. (This is likely related to the Interning error above)

The skipped test nullness/SameFileValidator.java behaves differently when caching is turned off. This test case uses raw types.

Lambdas might also have different behavior with caching off; Issue #573 is one example.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the AnnotatedTypeFactory and run the Value Checker, Interning Checker, and NullnessChecker tests named in the issue with caching enabled and disabled. Compare the reported failures, including value/Repo.java, interning/CompileTimeConstants.java, jtreg/rawtypes/RawTypeFail.java, and the listed nullness cases. Done means the results match in both modes, with remaining discrepancies accounted for.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
testing
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.