typetools / typetools/checker-framework
Possible optimization opportunity in MustCallConsistencyAnalyzer
Open
Nobody has claimed this yet.
ResourceLeakChecker
- Dominant language
- Java
- Stars
- 1.1k
- Forks
- 440
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 134
Description
For this code:
I think we can avoid calling getPath() here by passing down the CFG to this method. It should be possible to get the tree for the enclosing method via the CFG without calling getPath().
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in checker/src/main/java/org/checkerframework/checker/resourceleak/MustCallConsistencyAnalyzer.java at lines 1321-1326 and trace the method's callers and CFG handling. Determine how to obtain the enclosing method tree from the CFG without calling getPath(), then verify that the analyzer's existing behavior is preserved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- devtools
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100