typetools / typetools/checker-framework
Ensure soundness and good test coverage of StructuralEqualityComparer
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 1.1k
- Forks
- 440
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 134
Description
As a follow-up to #1964: https://github.com/typetools/checker-framework/blob/master/framework/src/main/java/org/checkerframework/framework/type/StructuralEqualityComparer.java always returns true for several corner cases.
For each of these methods, write a test case and the proper implementation of the corresponding check.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read framework/src/main/java/org/checkerframework/framework/type/StructuralEqualityComparer.java and follow-up issue #1964 first. Identify each method that returns true for a corner case, add a test for each, and implement the corresponding checks. Done means those cases have proper implementations and test coverage.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- devtools, testing-qa
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100