typetools / typetools/checker-framework

CompletionFailure exception handling

Open
#1,283 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
1.1k
Forks
440
Avg merge
1d 12h
Merged PRs (30d)
134

Description

If the class for a declaration annotation is not on the classpath but an element for that annotation is accessed, a CompletionFailure exception is thrown. Issues #309 and #348 are to occurrences of this problem. They were fixed by catching the exception and issuing a warning. We should create a method that calls AnnotationMirror#getAnnotationType().asElement() catches the CompletionFailure and issues the warning. Then we should replace all occurrences with calls to the new method.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Search the Checker Framework sources for calls to AnnotationMirror#getAnnotationType().asElement() and existing CompletionFailure handling. Start by comparing the fixes described in issues #309 and #348. Done means a shared method catches CompletionFailure, issues the warning, and all relevant occurrences use that method.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.