typesafegithub / typesafegithub/github-workflows-kt

Come up with long-term approach to exposing `copy(...)` method in binding classes

Open
#1,629 3 comments 0 reactions 1 assignee View on GitHub

@Vampire is already working on this.

Since Sep 27, 2024.

Dominant language
Kotlin
Stars
664
Forks
30
Avg merge
4d 19h
Merged PRs (30d)
5

Description

Kotlin 2.0.20 compiler started producing warnings if the primary constructor of a data class is private: https://kotlinlang.org/docs/whatsnew2020.html#data-class-copy-function-to-have-the-same-visibility-as-constructor

As a short-term approach, we just suppress the warning, and the customers get a warning on the call site which is independent of this library. However, we'd like to keep exposing this method, so let's discuss what options we have to choose once starting using Kotlin 2.1.0.

Discussion: https://kotlinlang.slack.com/archives/C02UUATR7RC/p1724584851609139

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.