typelevel / typelevel/weaver-test

Fatal exceptions hang the runner

Open
#85 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Scala
Stars
85
Forks
15
PR merge metrics
No merged PRs in 30d

Description

This issue was copied over from: https://github.com/disneystreaming/weaver-test/issues/651
It was opened by: kubukoz


Using 0.8.3, when you run this suite (or anything else that produces an exception of the "fatal" sort), it hangs the runner.

import weaver._

import cats.effect.IO

object DemoTestWeaver extends SimpleIOSuite {

  pureTest("demo") {
    throw new NoClassDefFoundError("fake exception")
  }
}

This is inconsistent with munit and scalatest's behavior, and hopefully it's something that can be fixed on weaver's side.

Related: #503

Repro project: https://github.com/kubukoz/demos/tree/sbt-weaver-hang

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running the supplied Scala reproducer or the linked repro project and confirm that a fatal exception hangs the runner. Then inspect the runner's fatal-exception handling and related issue #503; done means the suite terminates with the exception instead of hanging, consistently with the reported munit and scalatest behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
scala
Domain
testing
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.