typelevel / typelevel/weaver-test
DogFoodTests does not correctly check timestamps for logs
Open
Nobody has claimed this yet.
- Dominant language
- Scala
- Stars
- 85
- Forks
- 15
- PR merge metrics
- No merged PRs in 30d
Description
This issue was copied over from: https://github.com/disneystreaming/weaver-test/issues/332
It was opened by: amumurst
Running sbt -mem 8192 test locally this tests fails.
[info] welcome to sbt 1.5.4 (AdoptOpenJDK Java 1.8.0_282)
.....
[info] *************FAILURES**************
[info] weaver.framework.test.DogFoodTests
[info] - test suite outputs logs for failed tests 2s
[info] Values not equal: (modules/framework/cats/test/src/DogFoodTests.scala:84)
[info]
[info] - failure 0ms | - failure 0ms
[info] expected (src/main/DogFoodTests.scala:5) | expected (src/main/DogFoodTests.scala:5)
[info] |
[info] [INFO] [11]:54:35 [DogFoodTests.scala:5] this test | [INFO] [12]:54:35 [DogFoodTests.scala:5] this test
[info] [ERROR] [11]:54:35 [DogFoodTests.scala:5] has failed | [ERROR] [12]:54:35 [DogFoodTests.scala:5] has failed
[info] [DEBUG] [11]:54:35 [DogFoodTests.scala:5] with context | [DEBUG] [12]:54:35 [DogFoodTests.scala:5] with context
[info] a -> b | a -> b
[info] token -> <something> | token -> <something>
[info] request -> true | request -> true
I am located in
Standard time zone: UTC/GMT +1:00 hour
Daylight saving time: +1:00 hour
Current time zone offset: UTC/GMT +2:00 hours
Time zone abbreviation: CEST
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Run sbt -mem 8192 test and inspect modules/framework/cats/test/src/DogFoodTests.scala around line 84, where the timestamp comparison fails. Reproduce the failure in a non-UTC timezone and trace how the expected and actual log timestamps are constructed. Done means DogFoodTests passes while correctly checking timestamps in the reported timezone setting.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- scala
- Domain
- testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 43/100