typelevel / typelevel/weaver-test
SourceLocation relative-path logic may blow on Windows
Nobody has claimed this yet.
- Dominant language
- Scala
- Stars
- 85
- Forks
- 15
- PR merge metrics
- No merged PRs in 30d
Description
This issue was copied over from: https://github.com/disneystreaming/weaver-test/issues/364
It was opened by: Baccata
See https://github.com/VirtuslabRnD/scala-cli/pull/105/checks?check_run_id=3441114875
We may have to protect the logic against this, possibly by checking that the two paths have the same root ?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by examining the SourceLocation relative-path logic and the linked scala-cli check to reproduce the Windows failure. Determine what happens when the two paths have different roots, then verify that this case no longer causes the logic to fail and add regression coverage if the project’s existing tests provide a suitable location.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- scala
- Domain
- testing
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100