typelevel / typelevel/skunk

Insert completion when oids are enabled

Open
#74 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Scala
Stars
1.7k
Forks
175
Avg merge
5d 14h
Merged PRs (30d)
9

Description

Insert completion message parsing isn't going to work when table oids are enabled, so need to follow up here. Also see what happens with the statement causes multiple rows to be inserted, since they'll have different oids. May need to look at the PG source to figure this out.

See https://github.com/tpolecat/skunk/pull/72 for context.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the insert completion message parsing discussed in pull request #72, then inspect the PostgreSQL source or documentation for completion messages when table OIDs are enabled. Check the behavior for inserts affecting multiple rows with different OIDs. Done means the parsing behavior is defined and works for both OID-enabled and multi-row inserts.

Written by the indexing model from the issue text.

Assessment

Tech stack
postgres, scala
Domain
databases
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.