typelevel / typelevel/skunk

Strategy docs wrong?

Open
#654 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Scala
Stars
1.7k
Forks
175
Avg merge
5d 14h
Merged PRs (30d)
9

Description

    /**
     * This strategy supports built-in Postgres types only, and does not need a database round-trip
     * for initialization. This is the fastest strategy and is appropriate when you are not using
     * any user-defined types (this includes enums).
     */
    case object BuiltinsOnly extends Strategy

    /**
     * This strategy supports built-in Postgres types, as well as types that are defined in
     * namespaces on the session search path. This is the default strategy.
     */
    case object SearchPath extends Strategy

SearchPath indicates it's the default strategy but Session.pooled defaults to BuiltinsOnly. Is this comment incorrect?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Strategy definitions and the Session.pooled entry point mentioned in the issue. Compare the documented default with the actual default used by Session.pooled, then update the relevant comment if they disagree and verify the surrounding documentation still matches the behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
postgres, scala
Domain
databases
Issue type
Documentation
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.