Should AppliedFragment Monoid use spaces?
Open
Nobody has claimed this yet.
- Dominant language
- Scala
- Stars
- 1.7k
- Forks
- 175
- Avg merge
- 5d 14h
- Merged PRs (30d)
- 9
Description
When combining AppliedFragments, should we intercalcate a space? I think technically that would violate the Monoid rules but I think that is what callers would want 99% of the time.
/** `AppliedFragment` is a monoid. */
implicit val MonoidAppFragment: Monoid[AppliedFragment] =
new Monoid[AppliedFragment] {
def combine(x: AppliedFragment, y: AppliedFragment): AppliedFragment = x |+| y
def empty: AppliedFragment = AppliedFragment.empty
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the AppliedFragment MonoidAppFragment definition shown in the issue and inspect the callers that combine AppliedFragments. Evaluate whether inserting spaces preserves the intended monoid behavior and matches caller expectations. Done requires a maintainer decision on the semantics, followed by an agreed implementation or documentation of the chosen behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- scala
- Domain
- database
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100