typelevel / typelevel/scalacheck

Expose Gens for BigDecimal with provided scale

Open
#692 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Scala
Stars
2k
Forks
393
Avg merge
6h 42m
Merged PRs (30d)
4

Description

In #670, @non introduced two methods that return Gens with a provided scale:

def chooseBigDecimalScale(minScale: Int): Choose[BigDecimal]
def chooseJavaBigDecimalScale(minScale: Int): Choose[JavaDecimal]

Both of them are private. We should consider making them public.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Search the ScalaCheck source for chooseBigDecimalScale and chooseJavaBigDecimalScale, then review issue #670 for their introduction and intended scope. Done means determining whether both methods should be public and updating the relevant API coverage if the project has it.

Written by the indexing model from the issue text.

Assessment

Tech stack
scala
Domain
testing
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.