typelevel / typelevel/natchez

DDEntryPoint use active span in continueOrElseRoot

Open
#1,075 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Scala
Stars
340
Forks
76
Avg merge
1d 6h
Merged PRs (30d)
13

Description

dd-java-agent integrates automatically with some java server implementations already, e.g. netty. And so when using something like tapir-netty-server-cats in combination with natchez and DataDog I see two spans one for netty requests and other created by natchez, but they are not connected.
Would it make sense to you to consider checking activeSpan in DDEntryPoint during continueOrElseRoot ?
I can add PR if that's ok.
Thanks!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading DDEntryPoint and the continueOrElseRoot path, then inspect how the activeSpan from dd-java-agent relates to the Natchez span created by tapir-netty-server-cats. The change is complete when Netty and Natchez spans are connected rather than appearing as separate traces; the issue does not name a test file.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, scala
Domain
observability
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.