typelevel / typelevel/keypool

A resource can be acquired even from the closed pool

Open
#290 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Scala
Stars
39
Forks
18
Avg merge
8h 26m
Merged PRs (30d)
4

Description

keypool version: 0.4.7

Even when the state of the pool is PoolClosed a new resource can still be acquired.
Should an exception be thrown at this case?

Example:

val pool = KeyPool
  .Builder(
    (i: Int) => IO.ref(i),
    (r: Ref[IO, Int]) => IO.unit
  )
  .build
  
for {
  closedPool <- pool.use(kp => IO.pure(kp)) 
  _          <- closedPool.take(1).use { ref => 
    ref.get.flatMap(value => IO.println(s"created a new ref in the closed pool: $value"))
  }
} yield ()

Output:

created a new ref in the closed pool: 1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with the Scala example in the report, then trace how PoolClosed is handled during take. Confirm the intended closed-pool behavior with the existing pool lifecycle code and tests; done means a closed pool cannot acquire a new resource and the behavior is covered by a regression test.

Written by the indexing model from the issue text.

Assessment

Tech stack
scala
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.