Extending `Query` can result in an invalid schema that still parses
Open
Nobody has claimed this yet.
conformance
- Dominant language
- Scala
- Stars
- 189
- Forks
- 32
- Avg merge
- 18h 31m
- Merged PRs (30d)
- 37
Description
Extracted from a comment by @hugo-vrijswijk in https://github.com/typelevel/grackle/pull/876#pullrequestreview-4969701910:
There are some cases where an invalid schema could still be made (
type Query { foo: Int } extend schema { query: Undefined }orextend schema { query: Bar }; scalar Bar).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the two schema examples from the issue and inspect the schema parsing and validation entry points that accept them. Done means both invalid schemas are rejected rather than parsed successfully, with tests covering these cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- scala
- Domain
- api
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100