Reactive-streams interop is uncancelable
Nobody has claimed this yet.
- Dominant language
- Scala
- Stars
- 2.5k
- Forks
- 636
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 7
Description
The implementation still uses an uncancelable async_ call which will hang on CE 3.5: https://github.com/typelevel/fs2/blob/9c523441c8f1770faafb36e01c893218162cdb72/reactive-streams/src/main/scala/fs2/interop/reactivestreams/StreamSubscriber.scala#L223
The java flow interop is fixed, but the fix hasn't been released yet.
Since the reactive-streams interop seems to be deprecated in favor of the flow interop, perhaps just releasing the fixed flow interop is sufficient? Though I noticed that the compiler doesn't seem to actually show any deprecation warnings.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with reactive-streams/src/main/scala/fs2/interop/reactivestreams/StreamSubscriber.scala around line 223 and compare it with the already-fixed Java Flow interop. Confirm the uncancelable async_ behavior on CE 3.5, then determine whether releasing the Flow fix resolves this issue or whether the deprecated reactive-streams interop also needs a change; done means cancellation no longer hangs and deprecation behavior is understood.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- scala
- Domain
- stream-processing
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100