typelevel / typelevel/frameless

AVG and KMeans tests fix

Open
#717 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Scala
Stars
895
Forks
135
Avg merge
1d 16h
Merged PRs (30d)
3

Description

In terms of https://github.com/typelevel/frameless/pull/699 we intorduced some workarounds to the tests behavior. This task is to identify the issues in the generated property tests values and fix them rather than applied a workround with the tolerantRun.

This problem existed for a really long time.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review pull request #699 and the AVG and KMeans generated property tests, focusing on the values that required tolerantRun. Reproduce the current failures, identify why those generated values are problematic, and replace the workaround with corrected test data or generation. Done means the tests pass without tolerantRun.

Written by the indexing model from the issue text.

Assessment

Tech stack
scala, spark
Domain
machine-learning, testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.