typelevel / typelevel/feral

Deprecate/remove `INothing`?

Open
#191 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

question
Dominant language
Scala
Stars
195
Forks
53
PR merge metrics
No merged PRs in 30d

Description

To follow suit with https://github.com/typelevel/fs2/pull/2870.

@bpholt had an excellent minimization in https://github.com/typelevel/feral/pull/52#issuecomment-974246880 demonstrating why we needed INothing instead of Nothing. Unfortunately, subsequent refactors made it no longer applicable and I was unable to find another one, tracked in https://github.com/typelevel/feral/issues/73.

I took a quick try at replacing INothing with Nothing. So far I encountered two issues:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading lambda/shared/src/main/scala-3/feral/lambda/INothing.scala and the compile test around line 39 of lambda/shared/src/test/scala/feral/lambda/TracedHandlerSuite.scala. Reproduce the Scala 2 and Scala 3 behavior, then review the linked fs2 change and feral issue 73. Done means the project has a decided, tested path for retaining, deprecating, or removing INothing.

Written by the indexing model from the issue text.

Assessment

Tech stack
scala
Domain
backend
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.