Checkers and matchers should catch NullabilityUnknown -> NotNull
Nobody has claimed this yet.
- Dominant language
- Scala
- Stars
- 2.2k
- Forks
- 379
- Avg merge
- 14m
- Merged PRs (30d)
- 8
Description
I've been bit today by a query that yielded a null value in a NullabilityUnknown column. The query itself was covered with analysis checks. However, as far as I can see from Analysis code, if nullability of a column is unknown, nullability of the Get instance is not checked!
There's a comment about it, but I think this deserves its own issue.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in modules/core/src/main/scala/doobie/util/analysis.scala, especially the referenced comment around line 148, and trace how Analysis handles unknown column nullability. Done means the checkers and matchers catch a NullabilityUnknown column used where NotNull is expected; the issue does not name a test to run.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- scala
- Domain
- databases
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100