typelevel / typelevel/doobie

Redundant wording in `.check`

Open
#413 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Scala
Stars
2.2k
Forks
379
Avg merge
14m
Merged PRs (30d)
8

Description

I have a query that selects a nullable postgres NUMERIC into a Float. I get this when I .check it:

- NUMERIC (numeric) is ostensibly coercible to Option[Float] according to the JDBC
      specification but is not a recommended target type. Fix this by changing the
      schema type to REAL; or the Scala type to Option[BigDecimal] or
      Option[BigDecimal].

Specifically, to Option[BigDecimal] or Option[BigDecimal].

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the .check diagnostic that produces the JDBC coercion warning and search for the duplicated Option[BigDecimal] wording shown in the issue. Remove the repeated alternative, then verify that the nullable PostgreSQL NUMERIC-to-Float diagnostic presents each suggested target type once.

Written by the indexing model from the issue text.

Assessment

Tech stack
postgresql, scala
Domain
databases
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.