typelevel / typelevel/cats

drop/dropRight/take/takeRight on TraverseFilter

Open
#4,696 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Scala
Stars
5.5k
Forks
1.2k
Avg merge
2d 10h
Merged PRs (30d)
5

Description

it occurs to me, strictly speaking, all you need is the total length, current index, and the ability to remove to implement these methods. TraverseFilter seems to have all those.

Should we add those to TraverseFilter and optimize the implementations on the strict collections?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the TraverseFilter abstraction and the strict collection implementations that provide drop, dropRight, take, and takeRight. Determine whether the proposed methods and optimizations fit the existing API, then verify that the resulting behavior is covered consistently across these collections.

Written by the indexing model from the issue text.

Assessment

Tech stack
scala
Domain
data
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.