typelevel / typelevel/cats

Move contains_ from Foldable to UnorderedFoldable

Open
#2,867 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Scala
Stars
5.5k
Forks
1.2k
Avg merge
2d 10h
Merged PRs (30d)
5

Description

Hi!

contains_ defined in Foldable, not in UnorderedFoldable, so I can't do something like this:

val s: Set[Int] = Set(1, 2, 3)
s.contains_(42)

I'm not sure, but just moving contains_ from foldableSyntax to unorderedFoldableSyntax is breaking bin compat.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Scala syntax entry points named foldableSyntax and unorderedFoldableSyntax, and review how contains_ is currently exposed. Check the project's binary-compatibility constraints before deciding how to make Set[Int].contains_(42) available without breaking compatibility.

Written by the indexing model from the issue text.

Assessment

Tech stack
scala
Domain
api
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.