Duplicate method in WriterT
Nobody has claimed this yet.
- Dominant language
- Scala
- Stars
- 5.5k
- Forks
- 1.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 5
Description
Apparently liftF and valueT, in WriterT, do the same thing. Their signatures would be identical if not for that F: Applicative[F] in liftF which is useless given its implementation just uses map and Functor would suffice. Should we deprecate one of them? If yes which name should we keep? Also, in case we decide to keep liftF, I think we should relax the Applicative constraint and use Functor instead. I can issue a PR with the changes when we decide how to proceed.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the WriterT APIs named in the issue, liftF and valueT, and compare their signatures and implementations. Resolve which name should remain and whether liftF should use a Functor constraint; done means the API decision and any deprecation or constraint change are agreed and reflected consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- scala
- Domain
- backend-api-design
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100