typelevel / typelevel/cats

minimumOption and maximumOption could be on UnorderedFoldable

Open
#2,715 1 comment 6 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Scala
Stars
5.5k
Forks
1.2k
Avg merge
2d 10h
Merged PRs (30d)
5

Description

Order.max/min is commutative, so it could be used with UnorderedFoldable/UnorderedReducible.

They should be moved down there in cats 2.0, which I think would be binary compatible in scala 2.12 since UnorderedFoldable is a subtype of Foldable.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the definitions of minimumOption and maximumOption, along with UnorderedFoldable and UnorderedReducible. Check how moving these operations affects inheritance and Scala 2.12 binary compatibility. Done means the operations are available at the unordered abstraction without breaking the stated compatibility requirement.

Written by the indexing model from the issue text.

Assessment

Tech stack
scala
Domain
tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.