typelevel / typelevel/cats

ApplicativeError: catchNonFatal, catchNonFatalEval and fromTry are not covered by laws

Open
#1,908 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Scala
Stars
5.5k
Forks
1.2k
Avg merge
2d 10h
Merged PRs (30d)
5

Description

There are currently no laws in ApplicativeErrorLaws that cover:

  • catchNonFatal
  • catchNonFatalEval
  • fromTry

When I check the associated laws for a type-class, I expect to get full code coverage given good enough Arbitrary values.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with ApplicativeErrorLaws and inspect how existing laws are structured for the type class. Trace catchNonFatal, catchNonFatalEval, and fromTry, then add law coverage for these operations; done means associated laws exercise all three methods with suitable Arbitrary values.

Written by the indexing model from the issue text.

Assessment

Tech stack
scala
Domain
testing-qa
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.