typelevel / typelevel/cats-effect
DRY the constant definitions
Nobody has claimed this yet.
- Dominant language
- Scala
- Stars
- 2.2k
- Forks
- 576
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 18
Description
We define several constants for JVM in Java files and then again on JS/Native in Scala. I think the Java sources actually produces "less efficient" bytecode on the JVM than on JS/Native, because Scala final vals are directly inlined at each use site. I doubt this makes a difference in practice, but there's no need to maintain two copies of these definitions.
The hardest part of this issue is convincing Daniel S that we aren't trashing performance with this change 😝
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the duplicated JVM constant definitions in the Java sources and the Scala JS/Native sources, then inspect how each platform exposes and uses them. Compare the generated JVM bytecode and run the relevant cross-platform build and tests; done means one maintained set of definitions works across platforms without a performance regression.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, scala
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100