typelevel / typelevel/cats-effect
Remove TODO in `IOFiber.readBarrier()`
Open
Nobody has claimed this yet.
- Dominant language
- Scala
- Stars
- 2.2k
- Forks
- 576
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 18
Description
#4320
benchmark reference:
withBarrier (volatile) : ~5.2M ops/s
withoutBarrier (plain) : ~5.3M ops/s (unsafe for fibers)
javaFullFence : ~800K ops/s (overkill)
optimizing further makes no sense because VarHandle/Unsafe will introduce complexity for negligible gain. Plain reads break correctness. Volatile is just perfect.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the IOFiber.readBarrier() entry point and inspect the TODO it refers to, then read the benchmark context in this issue and #4320. Remove the TODO without changing the volatile barrier behavior, and confirm the resulting implementation still preserves fiber correctness.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- scala
- Domain
- backend, performance
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100