typelevel / typelevel/cats-effect
PureConc not running finalizers
Open
Nobody has claimed this yet.
:beetle: bug
- Dominant language
- Scala
- Stars
- 2.2k
- Forks
- 576
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 18
Description
I might be missing something completely obvious, but PureConc doesn't seem to run finalizers:
"foo" in {
val t: PureConc[Int, Int] = for {
c <- F.ref(0)
latch <- F.deferred[Unit]
fib <- F.start((latch.complete(()) *> F.never[Unit]).onCancel(c.update(_ + 1)))
_ <- latch.get
_ <- fib.cancel
v <- c.get
} yield v
pure.run(t) mustEqual Outcome.Succeeded(Some(1))
}
If I put this in PureConcSpec, it fails with:
Succeeded(Some(0)) != Succeeded(Some(1))
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in PureConcSpec with the provided reproducer and compare the observed Outcome.Succeeded(Some(0)) with the expected Some(1). Trace how PureConc handles fib.cancel and the onCancel finalizer, then confirm the behavior with the same test once cancellation runs the finalizer.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- scala
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100