typelevel / typelevel/cats-effect
Use `js.typeOf` checks for JS feature tests instead of try/catch
Nobody has claimed this yet.
- Dominant language
- Scala
- Stars
- 2.2k
- Forks
- 576
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 18
Description
This is my fault. I've been lazily using Try(js.Dynamic.global....) when I should be writing idiomatic code like this:
https://github.com/typelevel/cats-effect/blob/76d2602ea651a6f0035bef4f9aa506773a335c95/std/js/src/main/scala/cats/effect/std/JavaSecureRandom.scala#L77-L78
Today in the Discord there were reports of ReferenceError: Can't find variable: process. So time to fix this.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with std/js/src/main/scala/cats/effect/std/JavaSecureRandom.scala around lines 77-78, then search the Scala.js sources for Try(js.Dynamic.global...) feature checks. Replace the affected checks with js.typeOf-based checks so missing globals such as process no longer produce ReferenceError; verify the JS feature tests cover absent globals.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, scala
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100