twosigma / twosigma/beakerx

Add support for adding SQL query overrides to associated databases

Open
#8,134 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Jupyter Notebook
Stars
2.9k
Forks
383
PR merge metrics
No merged PRs in 30d

Description

Certain databases that have internal optimizers such as Derby and Splicemachine allow for passing overrides to the SQL query via specific comment structures:
In Derby: pass in `--DERBY-PROPERTIES constraint=cons1` after the FROM clause
In Splicemachine: pass in `--SPLICE-PROPERTIES constraint=cons1` after the FROM clause

The proposed fix for this is to modify [QueryParser.java](https://github.com/twosigma/beakerx/blob/master/kernel/sql/src/main/java/com/twosigma/beakerx/sql/QueryParser.java#L87)

To check for a list of accepted "overrides" and set `boolean mustBeDeleted` (the third parameter) to false if so.

I am happy to make the change and create the PR if desired.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.