twobin / twobin/react-lazyload
Overflow check for parent can be inclusive of any of the overflow condition
Open
- Dominant language
- JavaScript
- Stars
- 5.9k
- Forks
- 485
- PR merge metrics
- No merged PRs in 30d
Description
https://github.com/twobin/react-lazyload/blob/055405125d0313014f0951cffc78345297f10a08/src/utils/scrollParent.js#L30
- When using the `overflow:true` props it did not pick the correct parent and hence was not giving the desired effect.
- Since I was restricting the overflow on x axis and `scroll` on y axis the parent was ignored.
- We can use `or condition` to enable detection of any parent that has an overflow
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.