twobin / twobin/react-lazyload

prop-types needs to be a direct dependency, not dev

Open
#347 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
5.9k
Forks
485
PR merge metrics
No merged PRs in 30d

Description

With React 17 their own depencency on prop-types was removed, however it is needed for this package. In #91 this was fixed once, but broke again with [2ee646e42][1]. Now without this being resolved by a direct dep in a peer dep this issue is back.

[1]: https://github.com/twobin/react-lazyload/commit/2ee646e42#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L29

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.