twobin / twobin/react-lazyload

scrollContainer can't be set to a DOM node

Open
#260 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
5.9k
Forks
485
PR merge metrics
No merged PRs in 30d

Description

The documentation specifies that `scrollContainer` can be set to either a queryselector string, or a DOM node, and the propTypes reflect this as well.

Currently, if anything other than a string is passed as the value of `scrollContainer`, the value is ignored.

An object should be accepted instead of only a string.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.