handle addCleanup consistently between asynctest and synctest
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 6k
- Forks
- 1.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 10
Description
 |
@graingert reported |
|---|---|
| Trac ID | trac#9963 |
| Type | enhancement |
| Created | 2020-09-15 17:31:46Z |
in creating #9962 it was determined that there is an inconsistency between _asynctest and _synctest with regard to how cleanup callbacks are handled.
specifically in _asynctest callbacks added after the test has finished are not processed, but in _synctest they are
secondly code exists for special case handling of KeyboardInterrupt but it's unreachable.
using contextlib.ExitStack and contextlib2.AsyncExitStack should solve this in both cases
Searchable metadata
trac-id__9963 9963
type__enhancement enhancement
reporter__graingert graingert
priority__normal normal
milestone__None None
branch__
branch_author__
status__new new
resolution__None None
component__core core
keywords__None None
time__1600191106198966 1600191106198966
changetime__1600191183516674 1600191183516674
version__None None
owner__None None
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the _asynctest and _synctest implementations and compare how each processes cleanup callbacks added after test completion. Review contextlib.ExitStack and contextlib2.AsyncExitStack, then verify consistent cleanup behavior and the KeyboardInterrupt handling in the relevant test suite.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- testing-qa
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100