twisted / twisted/twisted

t.w.c._HTTP11ClientFactory starting/stopping log messages are (still) not useful

Open
#9,330 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement new priority-normal web
Dominant language
Python
Stars
6k
Forks
1.2k
Avg merge
2d 10h
Merged PRs (30d)
10

Description

glyph's avatar @glyph reported
Trac ID trac#9330
Type enhancement
Created 2017-11-16 19:16:59Z

While _HTTP11ClientFactory now includes repr()s of some other things, the original purpose of #9235 remains unfulfilled.

The log line in question needs to include the information originally stipulated:

  • The destination IP address of the TCP connection
  • The destination port of the TCP connection
  • The source IP address of the TCP connection
  • the source port of the TCP connection

Ideally, also, the URL whose fetch triggered the creation of the connection in the first place (even if the pool might retrieve multiple URLs over the same connection).

Perhaps this should be done by improving the repr()s of the various constitutent objects which it now includes, or perhaps the log message itself should change to incorporate more information, but we should ensure that this ticket not be closed without addressing those issues.

Searchable metadata
trac-id__9330 9330
type__enhancement enhancement
reporter__glyph glyph
priority__normal normal
milestone__None None
branch__ 
branch_author__ 
status__new new
resolution__None None
component__web web
keywords__None None
time__1510859819934733 1510859819934733
changetime__1514601422051253 1514601422051253
version__None None
owner__None None
cc__twm@...

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with _HTTP11ClientFactory and the requirements carried over from #9235; trace connection creation to determine where the TCP endpoints and triggering URL are available. Done means the starting and stopping log messages identify both destination and source IP addresses and ports, and include the URL when feasible.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
networking
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.