twisted / twisted/twisted

twisted.internet.task.Clock.callLater doesn't raise AssertionError for negative times

Open
#9,166 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug core new priority-normal
Dominant language
Python
Stars
6k
Forks
1.2k
Avg merge
2d 10h
Merged PRs (30d)
10

Description

bitglue's avatar @bitglue reported
Trac ID trac#9166
Type defect
Created 2017-06-08 22:26:51Z

ReactorBase.callLater() will raise an assertionError if the time is negative. For the benefit of unit tests expecting equivalent behavior, Clock.callLater() should do the same.

Searchable metadata
trac-id__9166 9166
type__defect defect
reporter__bitglue bitglue
priority__normal normal
milestone__None None
branch__ 
branch_author__ 
status__new new
resolution__None None
component__core core
keywords__None None
time__1496960811409022 1496960811409022
changetime__1497223715249773 1497223715249773
version__None None
owner__bitglue bitglue

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing twisted.internet.task.Clock.callLater() with ReactorBase.callLater(), focusing on how each handles negative times. Add the matching AssertionError behavior to Clock.callLater(), then run the existing task and reactor tests to confirm equivalent behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend, testing
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.