twisted.internet.testing.MemoryReactor should provide IReactorPluggableNameResolver
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 6k
- Forks
- 1.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 10
Description
 |
@markrwilliams reported |
|---|---|
| Trac ID | trac#9103 |
| Type | enhancement |
| Created | 2017-04-03 15:54:10Z |
#9032 broke code that passed twisted.internet.testing.MemoryReactor instances to twisted.internet.endpoints.HostnameEndpoint, because the latter came to require reactors provide IReactorPluggableNameResolver. Passing a reactor that doesn't provide this interface will be deprecated when #9032 gets closed, so MemoryReactor should provide it as soon as possible so that the deprecation schedule can be followed.
Searchable metadata
trac-id__9103 9103
type__enhancement enhancement
reporter__markrwilliams markrwilliams
priority__normal normal
milestone__None None
branch__
branch_author__
status__new new
resolution__None None
component__core core
keywords__MemoryReactor MemoryReactor
time__1491234850865358 1491234850865358
changetime__1565347209231185 1565347209231185
version__None None
owner__None None
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading twisted.internet.testing.MemoryReactor and twisted.internet.endpoints.HostnameEndpoint, then review issue #9032 for the interface requirement. Verify how IReactorPluggableNameResolver is expected to be provided and check the existing tests around MemoryReactor. Done means MemoryReactor provides the interface required by HostnameEndpoint without triggering the noted deprecation path.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- networking
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100