twisted / twisted/twisted

Backwards compatibility - Process identification string without \r\n

Open
#9,079 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

conch enhancement new priority-normal
Dominant language
Python
Stars
6k
Forks
1.2k
Avg merge
2d 10h
Merged PRs (30d)
10

Description

amv42's avatar @amv42 reported
Trac ID trac#9079
Type enhancement
Created 2017-03-15 16:01:38Z

According to Section 4.2 RFC 4253 (https://tools.ietf.org/html/rfc4253#section-4.2 ), “Implementers who wish to maintain compatibility with older, undocumented versions of this protocol may want to process the identification string without expecting the presence of the carriage return character for reasons described in Section 5 of this document.”\

Currently, Twisted Conch does not implement this feature.

Searchable metadata
trac-id__9079 9079
type__enhancement enhancement
reporter__amv42 amv42
priority__normal normal
milestone__None None
branch__ 
branch_author__None None
status__new new
resolution__None None
component__conch conch
keywords__None None
time__1489593698641082 1489593698641082
changetime__1489922342856835 1489922342856835
version__None None
owner__amv42 amv42

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading RFC 4253 Section 4.2 and the related Section 5 discussion, then trace Twisted Conch's SSH identification-string handling. Verify how the current implementation treats input without a carriage return and define tests that demonstrate compatibility with that form. Done means the behavior supports the RFC-described legacy identification string without breaking standard processing.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
networking
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.