Improve IOCP reactor accept reliability or documentation
Open
Nobody has claimed this yet.
core
enhancement
new
priority-normal
- Dominant language
- Python
- Stars
- 6k
- Forks
- 1.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 10
Description
| @adiroiban reported | |
|---|---|
| Trac ID | trac#7839 |
| Type | enhancement |
| Created | 2015-03-30 10:06:34Z |
Follow up on #5356
As discovered by our tests iocp reactor accept might fail
we should also document this or look at improving the code so that it will not fail
Looking at the previous discussion, it looks like one way to make success more likely would be to use GetOverlappedResult(..., wait=True). Microsoft does tend to fix issues like this in Windows (our XP builder has had several more it's-a-bug-in-Windows issues than our Win7 builder), so we should make it do the "right" thing first. I think this may also be the reason that large numbers of calls fail; although the close is called on cleanup, there might still be an outstanding pile of overlapped results pending someplace.
Searchable metadata
trac-id__7839 7839
type__enhancement enhancement
reporter__adiroiban adiroiban
priority__normal normal
milestone__
branch__
branch_author__
status__new new
resolution__None None
component__core core
keywords__
time__1427709994341951 1427709994341951
changetime__1427709994341951 1427709994341951
version__None None
owner__None None
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the discussion in #5356 and the tests that exposed failures in the IOCP reactor's accept path. Investigate the mentioned GetOverlappedResult(..., wait=True) behavior and determine whether the outcome should be a reliability improvement or documentation; done means the failure is addressed or the limitation is clearly documented.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- networking, operating-systems
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100