twisted / twisted/twisted

AMP.locateResponder should respect passed in locator, but doesn't

Open
#7,761 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

amp bug core new priority-normal
Dominant language
Python
Stars
6k
Forks
1.2k
Avg merge
2d 10h
Merged PRs (30d)
10

Description

itamarst's avatar @itamarst reported
Trac ID trac#7761
Type defect
Created 2015-01-30 15:17:11Z

If you pass in a custom locator AMP.locateResponder still tries to do lookup on the AMP instance, rather than on the passed in locator.

Searchable metadata
trac-id__7761 7761
type__defect defect
reporter__itamar itamar
priority__normal normal
milestone__ 
branch__ 
branch_author__ 
status__new new
resolution__None None
component__core core
keywords__amp amp
time__1422631031022103 1422631031022103
changetime__1422631031022103 1422631031022103
version__None None
owner__None None

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating AMP.locateResponder and trace how its locator argument is used during responder lookup. Reproduce the case with a custom locator, then verify that lookup occurs on the passed-in locator rather than the AMP instance.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
networking
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.