t.p.syslog doesn't support logLevel (reprise)
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 6k
- Forks
- 1.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 10
Description
| ioggstream reported | |
|---|---|
| Trac ID | trac#7549 |
| Type | enhancement |
| Created | 2014-08-01 13:26:38Z |
| Branch | https://github.com/twisted/twisted/tree/syslog-levels-7549-2 |
This thread seems to date back to 2009, so I'll retry.
Running an application using logLevel in twistd doesn't preserve logLevels
Reproduce:
- run #twistd --syslog ...
- wait for an event with logLevel=WARNING
I expect:
3. the log has syslogSeverity = LOG_WARNING
Instead
4. the syslogSeverity = DEFAULT == LOG_INFO
This is quite annoying because filtering logs via syslog could lead to losing important log informations.
The following code reproduces the issue. If you're interested in I'll provide a patch.
https://github.com/twisted/twisted/pull/44
Attachments:
- syslog-loglevels-7549.patch (5500 bytes) - added by ioggstream on 2014-12-03 21:35:09Z - logLevel support in t.p.syslog
- syslog-loglevels-7549-1.patch (5930 bytes) - added by ioggstream on 2015-02-09 10:25:33Z - syslog.py and newsfile
- syslog-loglevels-7549-2.patch (5707 bytes) - added by ioggstream on 2015-02-10 15:44:56Z - Accepted part of the first adiroban review
- syslog-loglevels-7549-3.patch (5861 bytes) - added by ioggstream on 2015-02-10 16:30:16Z - syslog log level support: added epydoc in test-helper method
- syslog-loglevels-7549-4.patch (5363 bytes) - added by ioggstream on 2015-03-17 09:01:48Z - Accepted twistedchecker complaints
Searchable metadata
trac-id__7549 7549
type__enhancement enhancement
reporter__ioggstream ioggstream
priority__normal normal
milestone__
branch__branches_syslog_levels_7549_2 branches/syslog-levels-7549-2
branch_author__adiroiban adiroiban
status__new new
resolution__
component__core core
keywords__
time__1406899598753263 1406899598753263
changetime__1430919235256654 1430919235256654
version__None None
owner__
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with t.p.syslog and the twistd --syslog path described in the reproduction, then review the attached syslog-levels patches for the prior implementation and review context. Reproduce a WARNING event and verify that its syslogSeverity is LOG_WARNING rather than the default LOG_INFO.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- observability
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100