twisted / twisted/twisted

Allow custom session cookie names

Open
#6,933 30 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement new priority-normal web
Dominant language
Python
Stars
6k
Forks
1.2k
Avg merge
2d 10h
Merged PRs (30d)
10

Description

adiroiban's avatar @adiroiban reported
Trac ID trac#6933
Type enhancement
Created 2014-01-28 20:40:44Z
Branch https://github.com/twisted/twisted/tree/custom-session-name-6933-4

Right now twisted session cookie is hardcoded.

Users wanting to use a different cookie name would need to overwrite whole t.w.s.Request.getSession() method.

Maybe we can find an API to specify the session name.

Attachments:

  • 6933-1.diff (2478 bytes) - added by adiroiban on 2014-01-28 20:55:11Z -
  • 6933-2.diff (113933 bytes) - added by adiroiban on 2014-02-09 11:58:12Z -
  • 6933-3.diff (7161 bytes) - added by adiroiban on 2014-02-09 14:46:17Z -
  • 6933-4.diff (7602 bytes) - added by adiroiban on 2014-03-03 12:23:22Z -
  • 6933-5.diff (7686 bytes) - added by adiroiban on 2014-11-11 15:36:54Z -
  • custom-cookie-prefix.patch (11132 bytes) - added by vladius on 2015-06-23 16:52:01Z - Custom cookie prefixes in the Site objects.
Searchable metadata
trac-id__6933 6933
type__enhancement enhancement
reporter__adiroiban adiroiban
priority__normal normal
milestone__ 
branch__branches_custom_session_name_6933_4 branches/custom-session-name-6933-4
branch_author__hawkowl__rwall__adiroiban__glyph hawkowl, rwall, adiroiban, glyph
status__new new
resolution__None None
component__web web
keywords__ 
time__1390941644000000 1390941644000000
changetime__1620471405825807 1620471405825807
version__None None
owner__vladius vladius
cc__jknight

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at t.w.s.Request.getSession(), the entry point named in the issue, and review the linked custom-session-name branch and attached diffs to understand the proposed API. Done means callers can configure a session cookie name without overriding getSession(), with existing session behavior preserved.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
web-dev
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.